microsoft / MixedRealityToolkit-Unity

This repository is for the legacy Mixed Reality Toolkit (MRTK) v2. For the latest version of the MRTK please visit https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity
https://aka.ms/mrtkdocs
MIT License
6k stars 2.12k forks source link

HoloToolkit-Example TextPrefabSamplesTest broken with Missing Prefab error #346

Closed NeerajW closed 7 years ago

NeerajW commented 7 years ago

Repro steps:

  1. Sync to latest master HTK-U
  2. Open project using Unity 5.4 releases
  3. Open HoloToolkit-Examples\Text\TextPrefabSamplesTest scene

Observe issue: image

I guess this could be due to either some different version of Unity being used to check in or may be the font dependency? The original prefabs look fine though. It's hard to tell what these prefabs are.

cre8ivepark commented 7 years ago

@NeerajW Those are the four text & sample prefabs added as part of #339 This test scene is just having them in the hierarchy. Let me try with different version. 2016-11-28 13_49_25-unity personal 64bit - textprefabsamplestest unity - textprefabtest5 - pc mac

NeerajW commented 7 years ago

@dbastienMS just mentioned to me that you might be missing meta files. True indeed: You don't have a meta file checked in for TextPrefabSamplesTest.meta Also missing meta files for you 3DTextPrefab and other files. Please add the meta files for all of them.

cre8ivepark commented 7 years ago

Created new pull request with added .meta files. Thank you!

NeerajW commented 7 years ago

Still broken. Looks like there is a Scripts.meta but no Scripts folder to go with it.

NeerajW commented 7 years ago

Great. That issue is now fixed :) Only new issue I see in the test scene is:

3DTextPrefab is missing the shader. This shader does not exist on the main prefab in UI\Prefabs. Perhaps this needs to be fixed:

  1. To point to HoloToolkit\3DTextShader
  2. Also apply this same shader to the prefab

image

StephenHodgson commented 7 years ago

@NeerajW the shader probably just needs to be recompiled.

NeerajW commented 7 years ago

@HodgsonSDAS nope. There was a shader namespace change and it had to be re-applied to the component.

NeerajW commented 7 years ago

Fixed with PR #351