search

microsoft / MixedRealityToolkit-Unity

This repository is for the legacy Mixed Reality Toolkit (MRTK) v2. For the latest version of the MRTK please visit https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity
https://aka.ms/mrtkdocs
MIT License
6k stars 2.12k forks source link

Text To Speech is missing in MRTK-v2.0.0-Beta2 #3569

Closed tletie closed 3 years ago

tletie commented 5 years ago

MRTK-v2.0.0-Beta2 (Unity package) doesn't port over "Text to speech" feature that exist in the holotoolkit. I don't see an example or tutorial how to implement this in this new toolkit. In the previous holotoolkit we do have TextToSpeechManager.cs to use.

Expected Behavior

Developer can just do text to speech using a port-over class TextToSpeechManager.cs

Actual Behavior

Can't find anything similar to do text to speech

Steps to reproduce

(Links to sample github project preferred)

Unity Editor Version

2018.3

Mixed Reality Toolkit Release Version

v2.0.0-Beta2

david-c-kline commented 5 years ago

Thanks for the feedback! We will definitely look into porting that functionality

genereddick commented 5 years ago

I added the TextToSpeech.cs file into the new MRTK and it worked as is.

tletie commented 5 years ago

Is that TextToSpeech.cs different TextToSpeechManager.cs I mentioned? Can you share the script so that I can test? Thanks

tletie commented 5 years ago

I think it the same. I use TextToSpeechManger.cs and it works too. Thanks

david-c-kline commented 5 years ago

Thanks @genereddick and @tletie! Text-to-Speech is platform specific (windows only) as implemented in HoloToolkit, The team will work to provide a cross platform implementation as soon as possible.

Do you feel it should be a foundational component or an extension? I can see both ways.

genereddick commented 5 years ago

The old code works on WMR/HoloLens and not anywhere else so my expectations for cross-platform are limited.

I do think if it can be done in a consistent way and across enough platforms than it would be great to have it as foundational, but I think an extension is fine if the platform differences are too challenging to abstract.

I wouldn't hold up a release for a cross-platform version in any case.

ActiveNick commented 4 years ago

Another alternative is to use the Cloud TTS API in Cognitive Services Speech. It won't work offline, but you'll get higher quality voices, a cross-platform SDK, and it provides consistent voices across all platforms. There is a Unity quickstart sample here.

ChristopherGoe commented 4 years ago

Hey, April 2020 and this is still not implemented or atleast I didn't found it in the current MRTK versions. Are there any plans on adding that? I had some hard time finding the old holotoolkit because most links are dead.

nonlin commented 4 years ago

I've started adding this to Unreal but it seems the release version I pulled from once compiled has... A. an error which is easily fixed but makes me wonder how the error is on release branch B. Just doesn't work.

I'm not sure why once a fresh pull of source setup, generated and compiled breaks MRTK 2 for hololens.

I'll keep digging into it to see if I can add TextToSpeech support for Unreal.