microsoft / MixedRealityToolkit-Unity

This repository is for the legacy Mixed Reality Toolkit (MRTK) v2. For the latest version of the MRTK please visit https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity
https://aka.ms/mrtkdocs
MIT License
5.99k stars 2.12k forks source link

Cleanup the EyeTracking Demo code and other HL2 artifacts #3767

Closed wiwei closed 5 years ago

wiwei commented 5 years ago

There's significant technical debt in the eye tracking demo code which we should clean up.

This has been filed to make sure we don't lose some of the interesting TODOs or comments in the following PR:

https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/3755

wiwei commented 5 years ago

InputPointVisualizer.cs had a large TODO:

/// ------------ /// TODO /// ------------ /// - Load log files /// - Replace GameObjects with particle systems for higher perf on HoloLens /// - Question: How to visualize data from multiple ppl? Color lookup table? Limit number of scanpaths visible at a time? /// - Question: How can users load files from HoloLens? Built-in file explore? Load by session? /// - Allow for tweaking parameters while viewing the scene, such as "transparency" etc. /// ------------

Also VisModes needs summaries.

wiwei commented 5 years ago

LogStructure_EyeGaze had a lot of TODO code (around raw eye gaze tracking) removed.

wiwei commented 5 years ago

OnSelect_VisualizerInputController.cs needs tooltips for its serialized fields

wiwei commented 5 years ago

ParticleHeatmap_ParticleData.cs needs a summary

wiwei commented 5 years ago

UserInput_Playback.cs needs significant cleanup (see the original PR)

wiwei commented 5 years ago

WindowsMixedRealityEyeGazeDataProvider.cs needs work around its confidenceOfSaccadeThreshold

wiwei commented 5 years ago

Need to also followup on Interactable.cs's

        if (!CanInteract() || true)
        {
            return;
        }

        if (StateManager != null)
        {
            if (eventData == null && (HasFocus || IsGlobal)) // handle brute force
            {
                StateManager.SetStateValue(InteractableStates.InteractableStateEnum.Visited, 1);
                IncreaseDimensionIndex();
                OnClick.Invoke();
            }
            else if (eventData != null && ShouldListen(eventData.MixedRealityInputAction))
            {
                StateManager.SetStateValue(InteractableStates.InteractableStateEnum.Visited, 1);
                IncreaseDimensionIndex();
                OnClick.Invoke();
                eventData.Use();
            }
        }
        */
Yoyozilla commented 5 years ago

I think this is done?

keveleigh commented 5 years ago

Some is in progress with #4032

Yoyozilla commented 5 years ago

4032 is merged. closing issue.