search

microsoft / MixedRealityToolkit-Unity

This repository is for the legacy Mixed Reality Toolkit (MRTK) v2. For the latest version of the MRTK please visit https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity
https://aka.ms/mrtkdocs
MIT License
6k stars 2.12k forks source link

Suggestion: used [obsolete] when you rename stuff #423

Closed LocalJoost closed 7 years ago

LocalJoost commented 7 years ago

Dear people,

I am trying to update a project that I made in September to the new version of the HoloToolkit. This is a painful process. For instance:

As Unity works, my whole project is broken now - no classes compile till all compile. How about at least using [obsolete] on members, or giving other hints when things have moved namespaces? And try to prevent moving namespaces at all - a 5.4 to 5.5 bump does not suggest breaking code.

Just my $0.05

StephenHodgson commented 7 years ago

Hi @LocalJoost. I definitely understand you pain, and I agree with marking things in the future obsolete.

It also doesn't help we're a bit behind on our documentation as well.

There is a tag to use for the last stable build before the breaking changes: https://github.com/Microsoft/HoloToolkit-Unity/releases

We had discussed the implications of making these breaking changes for nearly three months and came to the decision to make the plunge. The benefits outweighed the costs. Keep in mind that none of this is technically production ready and can be subject to volatile changes if hardware/OEM dependencies change.

LocalJoost commented 7 years ago

Thanks for your clarification. I think I am 'through the looking glass' now, and although it was a pain to get my app working again, I must admit the new structure works way better.

StephenHodgson commented 7 years ago

Glad to hear! We welcome your sharp eyes in future pull requests to help keep the quality of the toolkit at its highest.

Has this issue been resolved for you?

LocalJoost commented 7 years ago

Yes. I have the feeling though people are still a bit struggling here and there. Planning on a couple of blog post on it.