search

microsoft / MixedRealityToolkit-Unity

This repository is for the legacy Mixed Reality Toolkit (MRTK) v2. For the latest version of the MRTK please visit https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity
https://aka.ms/mrtkdocs
MIT License
6.01k stars 2.12k forks source link

Unity 5.5.1f1 Released #475

Closed g-bataille closed 7 years ago

g-bataille commented 7 years ago

Unity compiler errors with overriden Awake and OnDestroy noticely for the Singleton class. And with Holotoolkit.Sharing.SharingClientPINVOKE : unknown definitions

StephenHodgson commented 7 years ago

The HoloToolkit version is currently 5.5.0f3.

I'll take a look at updating to 5.5.1f1 today.

g-bataille commented 7 years ago

Thank you ! :)

StephenHodgson commented 7 years ago

Although this Known Issue doesn't bode well: https://unity3d.com/unity/whats-new/unity-5.5.1

  • Warning about missing object references in the inspector after upgraded to 5.5. We have only received one bug report and we have not been able to reproduce the issue. If you find some/all of your object references missing in the inspector do not save your scene. Quit the editor and re-open your project and the references should come back correctly.

But these are awesome:

  • AR: Fixed a crash when exiting play mode during a Holographic Simulation session. (858208)
  • HoloLens: Fixed a crash in Editor when terminating Remoting App during an active Holographic Remoting session.
  • HoloLens: Fixed resume-from-suspend bugs that would occasionally crash the app or not render anything. (800796, 851897, 825951)
  • HoloLens: Improved error reporting when failing to load PerceptionRemotingPlugin.dll (used by Holographic Remoting). (848237)
  • Core: Fixed hangs in the job system when running on certain platforms with a low number of cores e.g. older Windows Phones, UWP dual core machines. (791434)
  • Shaders: Optimized in-editor import, load time and memory usage for shaders with massive amounts of potential variants.
StephenHodgson commented 7 years ago

@g-bataille I didn't get any of these errors when upgrading.

Do these errors show up when you create a build?

[Edit] I was able to upgrade and and build to device without issues.

Check your build & player settings.

g-bataille commented 7 years ago

They appeared after I imported the last package, I then pulled the last commit but it didn't change the issue. Gonna try with a fresh new project.

StephenHodgson commented 7 years ago

So it happens when you import the HTK 1.5.5 asset package?

Or when you're pulling the project source?

[Edit] I was able to create a new project in 5.5.1f1 and import the 1.5.5 asset package without any issues.

g-bataille commented 7 years ago

Yup, same here, doesn't happen on a new project, the problem occured on an existing project.

StephenHodgson commented 7 years ago

It sounds like you need to do some work to get your existing project up to date with the HTK.

g-bataille commented 7 years ago

That was a very basic project without the holotoolkit integrated initially. Well I guess a strange side effect, maybe another package collided with holotoolkit, but I am sorted now :) I will post again if I succeed to repeat this issue. Thank you !

StephenHodgson commented 7 years ago

No worries! glad to hear you got it sorted out.

g-bataille commented 7 years ago

Thank you for your reactivity !

g-bataille commented 7 years ago

I confirm that this is due to a side effect generated by another package, gonna see that with the maintainer of the other package. Sorry for the inconvenience.

StephenHodgson commented 7 years ago

Well Patch 5.5.1p1 is out already haha.

  • HoloLens: Fixed a crash that occurs on device when downloading files with WWW.(860775 )
  • Mono: Correct an invalid C# compiler error with generic types in compiler generated code (like lambdas and enumerators). The error from the C# compiler often includes this text: "There is no boxing or type parameter conversion from..." (847798 )
  • Scripting: Added the following non-allocating accessors to Mesh. These accessors write into a user-specified List. The accessors are GetBindposes, GetBoneWeights, GetColors, GetIndices, GetNormals, GetTangents, GetTriangles, and GetVertices.

This last one is probably really great for spatial mapping and understanding.