Error message spam when hitting play and switching tabs in the inspector of the MRTK gameobject

microsoft / MixedRealityToolkit-Unity

This repository is for the legacy Mixed Reality Toolkit (MRTK) v2. For the latest version of the MRTK please visit https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity

https://aka.ms/mrtkdocs

MIT License

6.01k stars 2.12k forks source link

Error message spam when hitting play and switching tabs in the inspector of the MRTK gameobject #4944

Closed thalbern closed 5 years ago

thalbern commented 5 years ago

Describe the bug

There's a constant error spam in the console whenever you hit play in unity and then switch the tabs in the property inspector of the MRTK gameobject

To reproduce

Create a new project add the MRTK gameobject / playspace through the menu hit play select the mrtk gameobject in the inspector click eg on the Teleport tab

Your Setup (please complete the following information)

Unity Version 2018.4
MRTK Version v2.0 RC2.1

Target Platform (please complete the following information)

Unity

Railboy commented 5 years ago

This is caused by tab switching triggering a 'changed' event in the toolkit inspector, which tears down services. (The idea is if any profile has changed in any way we can't guarantee that service states will reflect the new profile data, so we tear everything down and start over.)

So we can break this down into two issues:

Changing an inspector tab shouldn't trigger 'changed' in the inspector
Tearing down services in play mode shouldn't cause errors

Related: #3945

Troy-Ferrell commented 5 years ago

@Railboy I agree, let's say issue #1 will be solved by PR = #4991

And leave issue #2 as tracked by #3945