microsoft / MixedRealityToolkit-Unity

This repository is for the legacy Mixed Reality Toolkit (MRTK) v2. For the latest version of the MRTK please visit https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity
https://aka.ms/mrtkdocs
MIT License
6k stars 2.12k forks source link

Add MRTK profile for build settings with possibility to implement custom code #4958

Closed benjamincoven closed 9 months ago

benjamincoven commented 5 years ago

Describe the problem

Hello,

I would like to be able to use the build window of the MRTK with some custom code that should be executed at each build. In the holotoolkit, I changed the code of the HTK build utilities but that's a dirty way.

Describe the solution you'd like

I think that it would be a good idea to create a dedicated profile for build settings with the possibility to add custom code (like a scriptable object to implement and to add to the profile?)

wiwei commented 5 years ago

@benjamincoven, do you have any more specifics on what places you want to hook? i.e. in what ways are you specifically looking to customize it?

benjamincoven commented 5 years ago

We are looking to automate the build pipeline (not with azure devops, sorry) and we had to change the build window script to do this:

For this (and some others suffs) we have our own "Build all" method that call BuildDeployWindow.BuildUnityProject and BuildDeployWindow.BuildAppx , also would it be better that these two methods return Task instead of void? We had also to change BuildUnity by adding an bool argument to determine if it should display the dialog "Build complete" or not.

All of these are still drafts for the moment but I hope you see better what I am asking. Thank you very much.

IssueSyncBot commented 9 months ago

We appreciate your feedback and thank you for reporting this issue.

Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority security issues. Unfortunately, this issue does not meet the necessary priority and will be closed. If you strongly feel that this issue deserves more attention, please open a new issue and explain why it is important.

Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.

Please note that MRTK3 was released in August 2023. It features an all-new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visit https://www.mixedrealitytoolkit.org.

Thank you for your continued support of the Mixed Reality Toolkit!