search

microsoft / MixedRealityToolkit-Unity

This repository is for the legacy Mixed Reality Toolkit (MRTK) v2. For the latest version of the MRTK please visit https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity
https://aka.ms/mrtkdocs
MIT License
6.01k stars 2.12k forks source link

⚠️ HoloToolkit no longer supports Unity 5.4.0f1-HTP #497

Closed riverar closed 7 years ago

riverar commented 7 years ago

I maintain https://holotoolkit.download and was running builds on Unity 5.4.0f1-HTP. Just a heads up that a recent change (https://github.com/Microsoft/HoloToolkit-Unity/commit/261802b9767fc3ee77e1e271da4f68235771fdce#diff-d7c8f5f8602786a2bff59bc9835eccf9R219) broke compatibility. It's not clear if this project is attempting to maintain Unity back compat. so no patch submitted at this time.

I plan on upgrading Unity on the server.

-----CompilerOutput:-stderr----------
Assets/HoloToolkit/Sharing/Scripts/Spawning/PrefabSpawnManager.cs(219,24):
error CS0266: Cannot implicitly convert type `UnityEngine.Object' to `UnityEngine.GameObject'.
An explicit conversion exists (are you missing a cast?)
-----EndCompilerOutput---------------
S-Hodgson-MMOARgames commented 7 years ago

I don't think it would be too difficult to revert that line, it was a trivial change.

Sorry about that @riverar. I'll have the fix in tomorrow.

thebanjomatic commented 7 years ago

I could be wrong, but I don't think there is any expectation that anything beyond the 1.5.4.0 release tag is compatible with Unity 5.4, with the current master branch targeting Unity 5.5 exclusively.

riverar commented 7 years ago

I upgraded my build box so you don't need to reinsert the cast. We might want to instead note in the Readme that Unity [v.current] is required. Seems more than fair for bleeding edge project.

StephenHodgson commented 7 years ago

No worries then.

The Editor version is noted in the readme. line 5.

There's been so many improvements and fixes specific for the HoloLens platform recently, it would probably be best to keep current.

riverar commented 7 years ago

Current Unity Editor Project Version isn't quite the same as Required Unity Editor Version. Suggest revisiting this. @NeerajW @HodgsonSDAS

StephenHodgson commented 7 years ago

It's now part of https://github.com/Microsoft/HoloToolkit-Unity/pull/496