microsoft / MixedRealityToolkit-Unity

This repository is for the legacy Mixed Reality Toolkit (MRTK) v2. For the latest version of the MRTK please visit https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity
https://aka.ms/mrtkdocs
MIT License
6k stars 2.12k forks source link

Rework how audio is managed #8009

Closed provencher closed 9 months ago

provencher commented 4 years ago

Describe the problem

Currently audio clips are added in an ad hoc way that is different for each interactible element in the MRTK. The slider has a script that is programmatically associates the clips to the script, while most other elements use the editor events to trigger audio clips.

With this system a number of problems arise:

Describe the solution you'd like

My ideal system would have two sets of scriptables objects

With a system like this, each object manipulator, button, etc, would have a field for the Interaction Audio Config, that could be set via code, or in the inspector, and it would update in one swoop all the clips used for that given interaction. Then, when iterating on audio, one could update that single config to change the audio for all buttons in a scene, without modifying each game object manually.

Additional context

I'm currently working with an audio designer to expand on the sound library of MRTK, for use in MRTK-Quest.

jasonhbartlett commented 4 years ago

This seems a great idea. I have been struggling with how button that trigger hiding itself on clicking don't have a chance to play the full clip. Looking for solutions to that as well.

provencher commented 3 years ago

Is there any activity on this issue? It remains a pain point for me.

I’ll add that having the ability to just get audio raised events would be great in case I want to have my own audio sources or a different audio system altogether.

anastasiadevana commented 3 years ago

Agreed that this is really painful. In addition, some people might be using a separate audio middleware (Wwise, FMOD, Master Audio, etc) which handles all audio.

I'd love to see some kind of audio handler system, where a developer can choose to completely take over all audio generation, and can just react to events in a uniform way (which action was performed and at which transform / game object).

Zee2 commented 2 years ago

Keeping this issue to track our AudioManager story. @davidkline-ms, what is the update on this story?

IssueSyncBot commented 9 months ago

We appreciate your feedback and thank you for reporting this issue.

Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority security issues. Unfortunately, this issue does not meet the necessary priority and will be closed. If you strongly feel that this issue deserves more attention, please open a new issue and explain why it is important.

Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.

Please note that MRTK3 was released in August 2023. It features an all-new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visit https://www.mixedrealitytoolkit.org.

Thank you for your continued support of the Mixed Reality Toolkit!