search

microsoft / MixedRealityToolkit-Unity

This repository is for the legacy Mixed Reality Toolkit (MRTK) v2. For the latest version of the MRTK please visit https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity
https://aka.ms/mrtkdocs
MIT License
6k stars 2.12k forks source link

ColorPicker Color Property, Events and Structure Dependency #8235

Closed jbienzms closed 9 months ago

jbienzms commented 4 years ago

I understand that ColorPicker is experimental, but I wanted to offer some feedback after attempting to use it tonight.

Color Property

First (and most important), there is no way to access the currently selected color outside of the control. I understand that the current design assumes the color picker will directly update a mesh or a sprite. However, I have cases were I'm already propagating a Color value out to various components in the scene. Therefore, all I really need access to is a Color.

The simplest solution would be to expose CustomColor publicly. However, it's also important to be able to handle this value changing at runtime. Either by custom code or by the inspector. This may require the use of an additional previousColor field behind the scenes.

Also, perhaps SelectedColor or even just Color might be better names for this property?

Events

Since I already have a mechanism for propagating color changes out to my scene, all I really need to know is when the color changes. If the Color property is public, then I can obviously monitor it on every Update loop. However, it would be nice to have an event that can notify me whenever the color value changes. Or, at the very least, when the picker is closed.

Structure Dependency

The current implementation of SummonColorPicker depends on specifically named objects. If this design remains intact, please add another override where the named elements can be passed. Or simply allow them to be set publicly. A simple Show method with no parameters would be valuable.

Thankfully TargetObjectMesh and TargetObjectSprite are both public, and it appears they can both be left null and the picker will still operate. This is all excellent. Please keep it working this way.

This component is very nice so far, and it's going to make a great addition to the MRTK!

jbienzms commented 4 years ago

Tagging @MRW-Eric @RogPodge since they were part of the initial contribution.

Zee2 commented 3 years ago

@MRW-Eric What is the state of this? Did this ever get fixed?

IssueSyncBot commented 9 months ago

We appreciate your feedback and thank you for reporting this issue.

Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority security issues. Unfortunately, this issue does not meet the necessary priority and will be closed. If you strongly feel that this issue deserves more attention, please open a new issue and explain why it is important.

Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.

Please note that MRTK3 was released in August 2023. It features an all new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visithttps://www.mixedrealitytoolkit.org.

Thank you for your continued support of the Mixed Reality Toolkit!