search

microsoft / MixedRealityToolkit-Unity

This repository is for the legacy Mixed Reality Toolkit (MRTK) v2. For the latest version of the MRTK please visit https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity
https://aka.ms/mrtkdocs
MIT License
6k stars 2.12k forks source link

Assertion failed on expression: '!name.empty()' on import of the Examples package #8440

Closed elbuhofantasma closed 9 months ago

elbuhofantasma commented 4 years ago

Describe the bug

When importing the Examples '.unitypackage', the Error "Assertion failed on expression: '!name.empty()'" was output in the Unity console. The Unity console does not display any other information about this Error.

To reproduce

Steps to reproduce the behavior:

  1. Create a new Unity 2019.4.9f1 project for the Standalone platform.
  2. Import the 2.5-20200901.2 Foundation package and deselect the Legacy XR option in the MRTK configuration prompt, then click apply.
  3. Import the 2.5-20200901.2 Examples package and deselect the Legacy XR option in the MRTK configuration prompt, then click apply.
  4. Check the Unity console output for this error.

Expected behavior

The Unity console should display more helpful information to the user when issues generated by the MRTK occur. There should also be no Errors when importing the '.unitypackage' for MRTK Examples.

Screenshots

Examplesimporterror

Your setup (please complete the following information)

Target platform (please complete the following information)

Additional context

Unity log output:


Assertion failed on expression: '!name.empty()' 
(Filename: C:\buildslave\unity\build\Editor/Src/AssetPipeline/AssetImporter.cpp Line: 401)

Done importing asset: 'Assets/MRTK/Examples/Demos/Gltf/Models/Cube/GLB/cube-with-custom-attr.glb' (target hash: 'd57eac617bb032d3e4d36697a6021407') in 0.286782 seconds ```
wiwei commented 4 years ago

I think we've seen this issue pop up in the past - it's a bit tricky because of the fact that the assertion is happening in Unity asset importing code.

We've also hit some other challenges associated with the GLTF loading code (right now we're still on a fork that has basically has diverged from the source quite a bit), so there might be a more holistic solution here involving doing the GLTF work correctly (i.e. as some non-forked approach, since it's caused issues around duplicate loaders and other things in the past)

elbuhofantasma commented 4 years ago

This issue also occurs on this commit: https://github.com/microsoft/MixedRealityToolkit-Unity/commit/a97278881a9a72d24326609fa40c963bce530442

polar-kev commented 3 years ago

We should look into this for the MRTK v3 public release.

IngGabriela commented 2 years ago

And is nothing to do by then?

stale[bot] commented 2 years ago

This issue has been marked as stale by an automated process because it has not had any recent activity. It will be automatically closed in 30 days if no further activity occurs. If this is still an issue please add a new comment with more recent details and repro steps.

IssueSyncBot commented 9 months ago

We appreciate your feedback and thank you for reporting this issue.

Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority security issues. Unfortunately, this issue does not meet the necessary priority and will be closed. If you strongly feel that this issue deserves more attention, please open a new issue and explain why it is important.

Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.

Please note that MRTK3 was released in August 2023. It features an all new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visithttps://www.mixedrealitytoolkit.org.

Thank you for your continued support of the Mixed Reality Toolkit!