microsoft / MixedRealityToolkit-Unity

This repository is for the legacy Mixed Reality Toolkit (MRTK) v2. For the latest version of the MRTK please visit https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity
https://aka.ms/mrtkdocs
MIT License
6.01k stars 2.12k forks source link

MRC not aligned with perspective of pv camera (XRSDK) #8707

Closed normanRV closed 3 years ago

normanRV commented 4 years ago

Describe the bug

When using Mixed Reality Capture holograms aren't aligned with pv camera (XRSDK). It seems that the transformation offset isn't considered when rendering from the pv camera. With mixed reality built-in xr platform integration hologram alignment ist correct. The problem exists only with XRSDK.

To reproduce

Steps to reproduce the behavior:

  1. Using mrtk InteractableExamples-scene
  2. Added mrtk + xrsdk
  3. Attach TrackedPoseDriver to MainCamera
  4. Using cloned DefaultXRSDKConfigurationProfile, just enabled Render from PVCamera
  5. Build XR SDK app to Hololens (ARM)

Expected behavior

Aligned holograms with PV camera

Screenshots

bugReport

20200929_123139_HoloLens

Your setup (please complete the following information)

Target platform (please complete the following information)

keveleigh commented 4 years ago

This is currently a known issue that we're tracking with Unity. I'll update this thread when I have more info!

polar-kev commented 3 years ago

Additional detailed repro steps captured in a duplicate issue https://github.com/microsoft/MixedRealityToolkit-Unity/issues/9169#issue-793922581

camnewnham commented 3 years ago

This is currently a known issue that we're tracking with Unity. I'll update this thread when I have more info!

Have there been any updates on this issue or is there a Unity bug tracker for it?

keveleigh commented 3 years ago

Apologies about my lack of update here. This should be fixed on the latest Windows XR Plugin across the latest Unity versions. I can narrow down the versions if needed, and please let me know if you're still seeing issues on the latest!

camnewnham commented 3 years ago

@keveleigh I can confirm that it's resolved and records correctly in the only configuration I tested: Unity 2020.3.12f1 with Windows XR Plugin 4.5.0

The warning from https://github.com/microsoft/MixedRealityToolkit-Unity/pull/9170 is still present in the MRTK MRC settings as of MRTK 2.7.2.0: image

Thanks!

keveleigh commented 3 years ago

@camnewnham Ah, thanks for pointing that out! It's probably been enough time that we can remove that now. I'll get it sorted tomorrow!

Hanning-Liu commented 6 months ago

@keveleigh Hi, I meet the same issue recently and I’m using MRTK3. How to set the “render from PV camera” function in MRTK3?

keveleigh commented 6 months ago

@keveleigh Hi, I meet the same issue recently and I’m using MRTK3. How to set the “render from PV camera” function in MRTK3?

I believe it's on by default now when you're using the Mixed Reality OpenXR Plugin. If you're looking to turn it off, there's a checkbox in the Mixed Reality Features settings: image

Hanning-Liu commented 6 months ago

@keveleigh Hi, I meet the same issue recently and I’m using MRTK3. How to set the “render from PV camera” function in MRTK3?

I believe it's on by default now when you're using the Mixed Reality OpenXR Plugin. If you're looking to turn it off, there's a checkbox in the Mixed Reality Features settings: image

Thank you for your reply! I’m using holographic remoting app now, is it possible to implement “render on PV camera” in this mode?

keveleigh commented 6 months ago

Thank you for your reply! I’m using holographic remoting app now, is it possible to implement “render on PV camera” in this mode?

I don't believe it used to be, but someone from Microsoft can comment on the current state of things (@AMollis? @yl-msft?)