search

microsoft / MixedRealityToolkit-Unity

This repository is for the legacy Mixed Reality Toolkit (MRTK) v2. For the latest version of the MRTK please visit https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity
https://aka.ms/mrtkdocs
MIT License
6k stars 2.12k forks source link

Unity 2017.2.0b8 has some breaking changes to the HTK #877

Closed jessemcculloch closed 7 years ago

jessemcculloch commented 7 years ago

Upgrading to 2017.2.0b8 has surfaced a few types that have changed names or I just can't find. To repro, just start a new project, and import the Dev_Unity_2017.2 version of the HTK, and the errors will surface themselves.

keveleigh commented 7 years ago

I have these changed in a local branch, so I can put out a pull request now.

StephenHodgson commented 7 years ago

There are lots of regressions in the beta 8 patch, it only addresses the security fix.

keveleigh commented 7 years ago

Where do you see an announcement that regressions are present? These changes align with my expectation as announced by Unity:

XR: Updated interfaces and new data for GestureRecognizer and InteractionManager (UnityEngine.VR.WSA.Input). Some of the API surface for this has breaking changes on the way and will land soon.

StephenHodgson commented 7 years ago

No I didn't see an announcement, but I figured it'd be included in the release notes at least.

XR: Updated interfaces and new data for GestureRecognizer and InteractionManager (UnityEngine.VR.WSA.Input). Some of the API surface for this has breaking changes on the way and will land soon.

Wasn't that was already addressed in b7?

b8 diff from b7

Improvements XR: XRDevice.SetTrackingSpaceType will now allow users to reason about where the floor is on VR HMDs for WindowsMR. Fixes Editor: Fixed exception when backspacing iOS target SDK version in PlayerSettings inspector. Editor: Fixed Security Vulnerability UNITY-SEC-844 - https://unity3d.com/security Physics: Ensure no work is done if the 2D physics world is empty. (940666) XR: Performance and stability during in-editor remoting has been improved for the HoloLens. (901423)

keveleigh commented 7 years ago

b7 didn't have any API changes: #873

It's strange that these API changes aren't called out in the release notes, but I've been using versions of Unity with these APIs from before the security vulnerability was found (8/13, according to that security page). See my old commit from the 10th (incorrectly labeled b7 updates as I misunderstood which version these APIs would be released in, and only found in my fork to compare against my b8 PR): https://github.com/keveleigh/HoloToolkit-Unity/commit/b082656a7f368333f406440f80d85e7dc649b11a

jessemcculloch commented 7 years ago

I agree with @keveleigh - These changes appeared in b8 even though they are not called out in the release notes. I was using a previous pull of the HTK MR Build in b7 and it was working fine