search

microsoft / MixedRealityToolkit-Unity

This repository is for the legacy Mixed Reality Toolkit (MRTK) v2. For the latest version of the MRTK please visit https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity
https://aka.ms/mrtkdocs
MIT License
6k stars 2.12k forks source link

MRTK Shader upgrade to LWRP/URP doesn't work #8852

Closed Acimaz closed 9 months ago

Acimaz commented 3 years ago

Describe the bug

Performing the Mixed Reality Toolkit -> Utilities -> Upgrade Mrtk Standard Shader for Lightweight Render Pipeline results in an error stating the following: "Failed to get asset path to: Mixed Reality Toolkit/Standard"

Full Log: Failed to get asset path to: Mixed Reality Toolkit/Standard UnityEngine.Debug:LogErrorFormat(String, Object[]) Microsoft.MixedReality.Toolkit.Editor.MixedRealityStandardShaderGUI:UpgradeShaderForLightweightRenderPipeline() (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@2.5.1/Core/Inspectors/MixedRealityStandardShaderGUI.cs:811)

To reproduce

Steps to reproduce the behavior:

  1. Go to 'Mixed Reality Toolkit -> Utilities'
  2. Click on 'Upgrade Mrtk Standard Shader for Lightweight Render Pipeline'
  3. See error

Expected behavior

It should upgrade the shader to work with URP (worked in the previous version without the package manager usage)

Your setup

keveleigh commented 3 years ago

Are you on a Mac? If so, this sounds related to https://github.com/microsoft/MixedRealityToolkit-Unity/issues/8826 and https://github.com/microsoft/MixedRealityToolkit-Unity/issues/8836

Acimaz commented 3 years ago

Yep, I'm on Mac. And yes, my materials also show "Hidden/InternalErrorShader" as used shaders.

stale[bot] commented 2 years ago

This issue has been marked as stale by an automated process because it has not had any recent activity. It will be automatically closed in 30 days if no further activity occurs. If this is still an issue please add a new comment with more recent details and repro steps.

IssueSyncBot commented 9 months ago

We appreciate your feedback and thank you for reporting this issue.

Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority security issues. Unfortunately, this issue does not meet the necessary priority and will be closed. If you strongly feel that this issue deserves more attention, please open a new issue and explain why it is important.

Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.

Please note that MRTK3 was released in August 2023. It features an all-new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visit https://www.mixedrealitytoolkit.org.

Thank you for your continued support of the Mixed Reality Toolkit!