microsoft / MixedRealityToolkit-Unity

This repository is for the legacy Mixed Reality Toolkit (MRTK) v2. For the latest version of the MRTK please visit https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity
https://aka.ms/mrtkdocs
MIT License
5.99k stars 2.12k forks source link

Editor inspector fails to display MRTK IconSet #9354

Closed philip-lamb closed 3 years ago

philip-lamb commented 3 years ago

Describe the bug

When selecting a MRTK IconSet in the Unity Editor, the icons are not displayed. Instead an error is displayed in the inspector "You can't nest FoldoutHeaders, end it with EndHeaderFoldoutGroup.".

To reproduce

Steps to reproduce the behavior:

  1. Install MRTK standard assets.
  2. Navigate to default IconSet
  3. Look at inspector pane

Expected behavior

Should see icons in set.

Screenshots

Screenshot 2021-02-22 125557

Your setup (please complete the following information)

Target platform (please complete the following information)

Additional context

atiemark commented 3 years ago

Having the same issue. Found a tempory workound to add my own icon by modifying the DefaultIconSet.asset in an editor (create a new entry with the GUID of the icon you want the add)

keveleigh commented 3 years ago

Hmm, I'm not able to fully repro. Am I missing anything? I'm able to view the asset, but unable to fold out any of the foldouts due to packages being immutable:

image

philip-lamb commented 3 years ago

I re-imported the project (close project, delete library folder, reopen, set platform and build settings) and I can't reproduce this now. At a guess it could have been some out of date asmdef.

MiPa12 commented 3 years ago

Hi, I'm having the same issue. Screenshot (41)

Your setup (please complete the following information) Unity 2020.3.11f1 MRTK 2.7.0

keveleigh commented 3 years ago

@RogPodge Was this an issue fixed by https://github.com/microsoft/MixedRealityToolkit-Unity/pull/9999?

RogPodge commented 3 years ago

Yep! should be fixed

daffy76 commented 2 years ago

same problem

istvanContXtual commented 2 years ago

Same problem,

Created a new icon set, Quad and Sprite Icons error in inspector panel: "You cant nest Foldout Headers, end it with EndHeatherFoldoutGroup"

MilanPolle commented 2 years ago

This problem still exists in MRTK 2.7.2

RogPodge commented 2 years ago

The fix is checked into the main repo but is not yet released in one of our official packages.

We are looking to put out a release which contains this bug fix before end of the year, so stay tuned

MilanPolle commented 2 years ago

Thank you for your reply! I downloaded the fix and applied it to the mrtk core package, this solved the problem.

kkyuri0419 commented 2 years ago

@MilanPolle I am facing the same issue with MRTK 2.7.2 May I ask what do you mean by you downloaded the fix?

MilanPolle commented 2 years ago

@kkyuri0419 the file with the fix is here: https://raw.githubusercontent.com/RogPodge/MixedRealityToolkit-Unity/02f3e41f650a14eb744b41507270fea0d0470d6a/Assets/MRTK/SDK/Features/UX/Scripts/Buttons/ButtonIconSet.cs

Open the /packages/MixedReality/ folder, in your Unity project and then open the .toolkit.foundation tgz file there (with 7Zip, for instance).

In the tgz file, navigate to /package/SDK/Features/UX/Scripts/Buttons/ and there you can replace the ButtonIconSet.cs file with the one you've downloaded.

Unity will process the changes by itself and then you should be able to add your icons in the editor without the errors that were there.

kkyuri0419 commented 2 years ago

@kkyuri0419 the file with the fix is here: https://raw.githubusercontent.com/RogPodge/MixedRealityToolkit-Unity/02f3e41f650a14eb744b41507270fea0d0470d6a/Assets/MRTK/SDK/Features/UX/Scripts/Buttons/ButtonIconSet.cs

Open the /packages/MixedReality/ folder, in your Unity project and then open the .toolkit.foundation tgz file there (with 7Zip, for instance).

In the tgz file, navigate to /package/SDK/Features/UX/Scripts/Buttons/ and there you can replace the ButtonIconSet.cs file with the one you've downloaded.

Unity will process the changes by itself and then you should be able to add your icons in the editor without the errors that were there.

Thank you so much @MilanPolle !! it perfectly works!

MilanPolle commented 2 years ago

@kkyuri0419 Glad to hear that! Thanks for letting me know.

jbienz commented 2 years ago

Just curious, since this was fixed in March what caused it to be missed in the 2.7.2 release? Also, would love to see this fixed in the next package release. It's kind of painful to apply the hotfix above and the next MRFT update will likely overwrite it. Thanks!

keveleigh commented 2 years ago

Just curious, since this was fixed in March what caused it to be missed in the 2.7.2 release?

The PR that fixed this was #9999, which was merged in June and just missed the 2.7.2 stabilization cutoff. It'll definitely be in our next release!

dvDevel commented 1 year ago

You may fix the bug with the link. The easiest way is to update to 2.7.3 fundamental with MixedRealityFeatureTool. In my case, nothing appears any errors after the update to 2.7.3.

Additionally. I tried exchanging Button IconSet.cs into tar at the package and tied it again. but It's not working.

이미지 003