microsoft / MixedRealityToolkit-Unity

This repository is for the legacy Mixed Reality Toolkit (MRTK) v2. For the latest version of the MRTK please visit https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity
https://aka.ms/mrtkdocs
MIT License
6k stars 2.12k forks source link

ObjectManipulator should use a smoothing function that's better for noisy hand input #9358

Closed krampster closed 9 months ago

krampster commented 3 years ago

Describe the bug

The current Smoothing.SmoothTo function performs a simple distance-based ease. There are other simple algorithms that would make manipulation feel more performant without increasing latency.

To reproduce

Steps to reproduce the behavior:

  1. Use an ObjectManipulator in the scene with near grabbable and smoothing.
  2. Grab it and move it with near interactions.
  3. Notice that the object drifts from your hand.

Expected behavior

When moving quickly, stability is not a goal. So use a smoother that takes distance into account such as this: return Vector3.Lerp(goal, source, Mathf.Pow(0.5f, Vector3.Distance(goal, source) / .02f)); Probably adjusting the constant to handle FPS changes.

Setup

Target platform

stale[bot] commented 2 years ago

This issue has been marked as stale by an automated process because it has not had any recent activity. It will be automatically closed in 30 days if no further activity occurs. If this is still an issue please add a new comment with more recent details and repro steps.

IssueSyncBot commented 9 months ago

We appreciate your feedback and thank you for reporting this issue.

Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority security issues. Unfortunately, this issue does not meet the necessary priority and will be closed. If you strongly feel that this issue deserves more attention, please open a new issue and explain why it is important.

Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.

Please note that MRTK3 was released in August 2023. It features an all-new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visit https://www.mixedrealitytoolkit.org.

Thank you for your continued support of the Mixed Reality Toolkit!