microsoft / MixedRealityToolkit-Unity

This repository is for the legacy Mixed Reality Toolkit (MRTK) v2. For the latest version of the MRTK please visit https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity
https://aka.ms/mrtkdocs
MIT License
6k stars 2.12k forks source link

MinMaxScaleConstraint allows scaling infinitely #9360

Closed jjimenezg93 closed 9 months ago

jjimenezg93 commented 3 years ago

Describe the bug

When adding a MinMaxScaleConstraint with RelativeToInitialState == true, the constraint is relative to the state at interaction start, not relative to the state at object initialization. Therefore, one can scale up/down until the limit, stop and restart the interaction to keep scaling infinitely.

To reproduce

Steps to reproduce the behavior:

  1. Go to 'BoundsControlExamples'.
  2. In the scene's hierarchy, click on 'SceneContent > CoffeeCups' and select one of them.
  3. In the inspector, add one MinMaxScaleConstraint.
  4. Configure its RelativeToInitialState to true and any min/max scale limits.
  5. Play the scene.
  6. Grab one of the corner handles of the cup.
  7. Scale up or down up to the point allowed by the constraint.
  8. Stop grabbing.
  9. Repeat 6-8 infinitely (always in the same direction, up or down).

Expected behavior

The scale is relative to that of the object at initialization time instead of interaction's start, so repeating steps 6-8 doesn't scale past the configured limit.

Your setup (please complete the following information)

Target platform (please complete the following information)

stale[bot] commented 2 years ago

This issue has been marked as stale by an automated process because it has not had any recent activity. It will be automatically closed in 30 days if no further activity occurs. If this is still an issue please add a new comment with more recent details and repro steps.

IssueSyncBot commented 9 months ago

We appreciate your feedback and thank you for reporting this issue.

Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority security issues. Unfortunately, this issue does not meet the necessary priority and will be closed. If you strongly feel that this issue deserves more attention, please open a new issue and explain why it is important.

Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.

Please note that MRTK3 was released in August 2023. It features an all-new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visit https://www.mixedrealitytoolkit.org.

Thank you for your continued support of the Mixed Reality Toolkit!