search

microsoft / MixedRealityToolkit-Unity

This repository is for the legacy Mixed Reality Toolkit (MRTK) v2. For the latest version of the MRTK please visit https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity
https://aka.ms/mrtkdocs
MIT License
6k stars 2.12k forks source link

Multiple events are triggered when hold gesture is not precise #9698

Closed kaushikwavhal closed 9 months ago

kaushikwavhal commented 3 years ago

Describe the bug

I was trying to play with Oculus Quest and MRTK. I setup MRTK in a blank unity project and loaded the hand interaction scene. As i was starting to interact with the scene, i noticed there's some heavy flickering of the hand ray when the ray falls on certain items. Later i released that it occurred when the ray was pointed to certain areas. Areas which will register click or move events. I've attached a YouTube video and a GIF below. The YouTube video includes the sounds that these events fire. You can judge by the sounds that these events are being fired in a loop like succession.

To reproduce

Steps to reproduce the behavior:

  1. Setup MRTK v2.6.0 on Unity v2020.3.4f1
  2. Load and Run Hand Interaction Example scene on Quest.
  3. Use Hand gestures to interact with the objects in the scene.

Expected behavior

The hand ray shouldn't stutter and multiple events should not be fired when the pinch gesture in in incomplete state.

Youtube Video

Youtube Video

Your setup (please complete the following information)

Target platform

Oculus Quest

keveleigh commented 3 years ago

This sounds like the bug that should be fixed by https://github.com/microsoft/MixedRealityToolkit-Unity/pull/9576. FYI @RogPodge Looks like it should have shipped in our 2.7.0-preview.3 package, if you want to take a look!

kaushikwavhal commented 3 years ago

This sounds like the bug that should be fixed by #9576. FYI @RogPodge Looks like it should have shipped in our 2.7.0-preview.3 package, if you want to take a look!

With these changes, it seems to have gotten rid of the flicker . Another issue with this fix is that the gesture still emits the event even if there sizable gab between the index finger and the thumb. Although that's not much of a problem unlike the flickering one.

RogPodge commented 3 years ago

yeah currently the minimum pinch distance to determine whether an event ought to be raised isn't configurable outside of the code.

If it's alright, can you raise an issue for us to track to make the pinch sensitivity configurable, and we can try to get it in a future release! We could then also close this issue at the same time @kaushikwavhal

stale[bot] commented 2 years ago

This issue has been marked as stale by an automated process because it has not had any recent activity. It will be automatically closed in 30 days if no further activity occurs. If this is still an issue please add a new comment with more recent details and repro steps.

IssueSyncBot commented 9 months ago

We appreciate your feedback and thank you for reporting this issue.

Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority issues. Unfortunately, this issue does not meet the necessary priority and will be closed. If you strongly feel that this issue deserves more attention, please open a new issue and explain why it is important.

Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.

Please note that MRTK3 was released in August 2023. It features an all-new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visit https://www.mixedrealitytoolkit.org.

Thank you for your continued support of the Mixed Reality Toolkit!