search

microsoft / MixedRealityToolkit

The MixedRealityToolkit is a collection of scripts and components intended to accelerate the development of mixed reality applications targeting Windows Mixed Reality.
MIT License
859 stars 277 forks source link

Refactoring SpectatorView Plugin #209

Closed chrisfromwork closed 5 years ago

chrisfromwork commented 5 years ago

This refactor is related to work in https://github.com/Microsoft/MixedRealityToolkit-Unity/tree/feature/spectatorView

Changes include the following: 1) The dll is reformatted so that plugin functions use float arrays/pointers. This avoids having to call unsafe code in the C# wrapper class within unity. 2) The dll is reformatted to require camera intrinsic and lens distortion values when detecting markers. These values can be obtained via a new HoloLensCamera wrapper (https://github.com/chrisfromwork/MixedRealityToolkit-Unity/blob/refactorMarkerDetection/Assets/MixedRealityToolkit.Extensions/SpectatorView/Scripts/Utilities/HoloLensCamera.cs )

provencher commented 5 years ago

Don't have much to add beyond it being really nice to see a more flexible approach with the distortion coefficients and the camera configuration settings.