search

microsoft / MixedRealityToolkit

The MixedRealityToolkit is a collection of scripts and components intended to accelerate the development of mixed reality applications targeting Windows Mixed Reality.
MIT License
856 stars 276 forks source link

Merge SpectatorViewPlugin refactor into mrtk_development #213

Closed chrisfromwork closed 5 years ago

chrisfromwork commented 5 years ago

This change moves the refactored spectator view plugin code into master. We will be migrating folks onto mrtk v2 and they will need this version of the code.

Lets not check this in until we have already integrated the Unity related work into the MRTK.

chrisfromwork commented 5 years ago

Please review this, I will hold off on checking this in until feature/spectatorView is checked into mrtk_development for MixedRealityToolkit-Unity

chrisfromwork commented 5 years ago

@wiwei @keveleigh @davidkline-ms @andreiborodin does anyone have any thoughts on whether c# api wrappers should be included in this repo? It feels like an api wrapper script should probably be version controlled and paired with the dll. This plugin requires one https://github.com/chrisfromwork/MixedRealityToolkit-Unity/blob/spectatorViewReadMe/Assets/MixedRealityToolkit.Extensions/SpectatorView/Scripts/MarkerDetection/ArUco/HoloLens/SpectatorViewPluginAPI.cs

wiwei commented 5 years ago

It feels like this code should be paired with the C# wrapper code, unless we really expect other people to want to write their own wrappers.

chrisfromwork commented 5 years ago

@wiwei i may keep this as is right now without the c# wrapper. I think that if we get to a nuget package distribution of this code with versioning we should include the c# wrapper in said nuget package. But right now that would require an additional setup step to reconfigure the spectator view prefab to use said script for marker detection.