microsoft / MixedRealityToolkit

The MixedRealityToolkit is a collection of scripts and components intended to accelerate the development of mixed reality applications targeting Windows Mixed Reality.
MIT License
856 stars 276 forks source link

Add calibration logic to spectator view plugin #220

Closed chrisfromwork closed 5 years ago

chrisfromwork commented 5 years ago

This change adds calibration logic to the spectator view plugin. 1) Camera intrinsics can now be calculated using the plugin and chessboard images 2) Camera extrinsics can now be calculated using the plugin, aruco images and aruco corner locations in the unity world space 3) A tool is now provided for creating a qr code/aruco calibration board

Note: We now have two plugin dll's (SpectatorViewPlugin and SpectatorViewPlugin.Editor). SpectatorViewPlugin uses the uwp opencv build and can be used in uwp applications. SpectatorViewPlugin.Editor uses the desktop opencv build and can be used in the unity editor.

wiwei commented 5 years ago

These precompiled headers aren't actually used - I would either delete them or move your acurco includes into the .h

include <opencv2\aruco.hpp>

include <opencv2\highgui.hpp>

Yeah I left the comment on the .cpp but yeah I think it's more for the .h


Refers to: SpectatorViewPlugin/SpectatorViewPlugin/CalibrationBoardGenerator/pch.cpp:6 in 71675a9. [](commit_id = 71675a9ca8b5b66a410b0e2fe4c3c712f9d68fe9, deletion_comment = False)