search

microsoft / Network-Adapter-Class-Extension

Network Adapter Class Extension to WDF (NetAdapter Cx) makes it easy to write high quality and high speed drivers for Network Interface Controllers
MIT License
54 stars 17 forks source link

NxConfiguration::QueryUlong() does not correctly validate the type of the data returned from NdisWdfReadConfiguration(). #6

Closed andrew-lee closed 6 years ago

andrew-lee commented 7 years ago

The code at lines 367-368 of nxconfiguration.cpp should be checking ndisConfigurationParam->ParameterType rather than ndisParamType. The fix should be something like:

if ((NdisParameterInteger != ndisConfigurationParam->ParameterType) &&
    (NdisParameterHexInteger != ndisConfigurationParam->ParameterType)) {
GabrielGravena commented 7 years ago

Hi Andrew, thanks for reporting this issue. It will be fixed in the next release of Windows.

tylerretzlaff commented 6 years ago

hi andrew,

thank you again for reporting the issue it should now be resolved with the recent import of the windows 10 april 2018 update (build 1803)