search

microsoft / Nova

Nova: High-speed recursive arguments from folding schemes
MIT License
673 stars 176 forks source link

Remove redundant absorbing to the transcript #284

Closed storojs72 closed 6 months ago

storojs72 commented 6 months ago

One of CompressedSNARK's verification steps (affects only ppspartan.rs) - checking the satisfiability of the folded instances (link) - has following redundant absorption of eval_vec to the transcript, since it is already happened here. Absorbing the same value twice adds no new entropy to the transcript, so second one can be freely removed.

I'm happy to provide a hotfix for this in case if core contributors confirm the issue

srinathsetty commented 6 months ago

Hi @storojs72, thanks the report! Yes, they are indeed absorbed twice (this is not a correctness issue, but a cost that does not need to be paid). Yes, please submit a fix.