microsoft / Nova

Nova: High-speed recursive arguments from folding schemes
MIT License
673 stars 176 forks source link

Improve error handling #286

Closed jbearer closed 6 months ago

jbearer commented 6 months ago

This commit only fixes low-hanging fruit in lib.rs, for functions that already return a Result and can easily propagate errors just by replacing expect(...) with ?. There are still many unwrap() calls in functions returning Result in other modules, particularly gadgets. But I don't understand the code well in those parts, and I suspect some of those unwrap()s actually can't fail based on invariants of the code, so it makes perfect sense to leave them as is.

jbearer commented 6 months ago

@microsoft-github-policy-service agree