search

microsoft / Nova

Nova: High-speed recursive arguments from folding schemes
MIT License
673 stars 176 forks source link

feat: make r1cs compoents public #306

Closed RyanKung closed 4 months ago

RyanKung commented 4 months ago

For now, mod r1cs and it's components are private, this PR aims to make them public, thus can be used outside nova repo.

RyanKung commented 4 months ago

@microsoft-github-policy-service agree [company="{Rings Network}"]

RyanKung commented 4 months ago

@microsoft-github-policy-service agree company="rings network"

srinathsetty commented 4 months ago

Hi @RyanKung Could you clarify the need to use R1CS-related types through Nova's APIs?

A key principle in Nova is to minimize public APIs so users of Nova work with a simple API. In that vein, the R1CS module is expected to be internal-only types. So, can you please clarify your use case?

RyanKung commented 4 months ago

Hi @RyanKung Could you clarify the need to use R1CS-related types through Nova's APIs?

A key principle in Nova is to minimize public APIs so users of Nova work with a simple API. In that vein, the R1CS module is expected to be internal-only types. So, can you please clarify your use case?

I hope to implement my own fold algorithm externally, so I hope Nova's private modules can have appropriate permissions. If this does not align with Nova's design purpose, it's OK to close this PR.

srinathsetty commented 4 months ago

Hi @RyanKung Could you clarify the need to use R1CS-related types through Nova's APIs? A key principle in Nova is to minimize public APIs so users of Nova work with a simple API. In that vein, the R1CS module is expected to be internal-only types. So, can you please clarify your use case?

I hope to implement my own fold algorithm externally, so I hope Nova's private modules can have appropriate permissions. If this does not align with Nova's design purpose, it's OK to close this PR.

Even if we make r1cs module public, it is not clear it will help you build your own folding scheme. The repo is not parameterized by the folding scheme yet.