microsoft / Olive

Olive: Simplify ML Model Finetuning, Conversion, Quantization, and Optimization for CPUs, GPUs and NPUs.
https://microsoft.github.io/Olive/
MIT License
1.63k stars 174 forks source link

`olive shared-cache` throws exception #1509

Closed cecheta closed 10 hours ago

cecheta commented 1 day ago

Describe the bug Using olive shared-cache commands throws an exception.

To Reproduce

Expected behavior No error occurs.

Olive logs

Traceback (most recent call last):
  File "/home/codespace/.python/current/bin/olive", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/usr/local/python/3.12.1/lib/python3.12/site-packages/olive/cli/launcher.py", line 62, in main
    service.run()
  File "/usr/local/python/3.12.1/lib/python3.12/site-packages/olive/cli/shared_cache.py", line 53, in run
    container_client_factory = AzureContainerClientFactory(
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/python/3.12.1/lib/python3.12/site-packages/olive/common/container_client_factory.py", line 21, in __init__
    credential=get_credentials(**credential_kwargs),
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: get_credentials() got an unexpected keyword argument 'exclude_managed_identity_credential'

Other information

xiaoyu-work commented 1 day ago

Thanks for reporting this. A PR had been created to fix this.

jambayk commented 10 hours ago

Fixed by #1513