microsoft / Omex

Shared components used by the Omex team to build scalable and highly available distributed systems
MIT License
71 stars 40 forks source link

Add more helper methods for settings result on Activity #265

Closed AndreyTretyak closed 4 years ago

AndreyTretyak commented 4 years ago

Currently, activity has extension methods https://github.com/microsoft/Omex/blob/a6ac88ec960000bc14562fa2215a7bbb8b486140/src/Extensions/Abstractions/Activities/ActivityExtensions.cs#L60

It looks like they are using a lot, so it would be nice to have additions methods to simplify interactions, for example:

public static Activity MarkAsSuccess(this Activity activity) { ... }
public static Activity MarkAsSystemError(this Activity activity) { ... }
public static Activity MarkAsExpectedError(this Activity activity) { ... }

They would be calling SetResult inside, also some simple unit tests needed for it.

MatusTomko commented 4 years ago

i want to do this isssue

MatusTomko commented 4 years ago

@AndreyTretyak how can i push my changes there?

AndreyTretyak commented 4 years ago

@MatusTomko you need to

  1. fork a repository image
  2. Then you would be able to push your local branch to the forked repository (if you already have a branch in your local copy you can just replace the URL of the remote or add a second remote to push). https://docs.github.com/en/free-pro-team@latest/github/using-git/changing-a-remotes-url
  3. Then you can use GitHub UI to create a pull request from a branch in your fork into the master of this repository. https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request

Please let me know if you would have problems with any of the steps.

MatusTomko commented 4 years ago

@AndreyTretyak I have a problem with Perform CodeQL Analysis, do you know what is problem? image

AndreyTretyak commented 4 years ago

@MatusTomko I think it was intermittent (that build stage not required), I've restarted pipelines and it looks successful now.