microsoft / OpenHack-FHIR

This repository hosts the guidance and assets for delivering an OpenHack focusing on FHIR and Microsoft's API for FHIR.
Creative Commons Attribution 4.0 International
89 stars 41 forks source link

Error when creating App Registrations (PowerShell and Cloud Shell) #34

Open mullis623 opened 2 years ago

mullis623 commented 2 years ago

When using the PowerShell method or the Cloud Shell method I am getting an error when trying to create App Registrations:

Cloud Shell: image 1st Error: Deploy\Scripts\openhack-fhir-auth-config.sh - Line 42

PowerShell: image 1st Error: deploy\scripts\fhir-server\samples\scripts\PowerShell\FhirServer\Public\New-FhirServerApiApplicationRegistration.ps1 - Line 68

It looks like this is being caused by a breaking change in AzureAD which have new requirements for the AppId Uri: https://docs.microsoft.com/en-us/azure/active-directory/develop/reference-breaking-changes#appid-uri-in-single-tenant-applications-will-require-use-of-default-scheme-or-verified-domains

I believe this could be resolved by appending the domain name to the end of the ServiceURL when creating App Registrations, but Im not sure what downstream effects that will have on this OpenHack.

rob-mckenna commented 2 years ago

@mullis623, we are working on testing the fix for this issue.

ravenugo commented 2 years ago

@rob-mckenna Any update on the fix? Also what's fix, that we can for timebeing do it on our local and cross this challenge 1.