search

microsoft / OpenXR-MixedReality

OpenXR samples and preview headers for HoloLens and Windows Mixed Reality developers familiar with Visual Studio
https://aka.ms/openxr
MIT License
336 stars 96 forks source link

Changes to make XrSceneUnderstanding.h more widely usable #68

Closed chrisfromwork closed 3 years ago

chrisfromwork commented 3 years ago

This review has the following changes:

  1. ostream is included through a reference to allow for directly referencing XrSceneUnderstanding.h
  2. Functions based on xr::ExtensionContext are updated to only require the xr::ExtensionDispatchTable. None of the xr::ExtensionContext specific functionality is used in this header. Basing functions off xr::ExtensionDispatchTable allows objects inheriting from xr::ExtensionDispatchTable to be used.
  3. Helper functions were added for obtaining scene planes