search

microsoft / OpenXR-Unity-MixedReality-Samples

Sample Unity projects to demo how to use OpenXR plugin in Unity for HoloLens 2 and Mixed Reality headsets
MIT License
244 stars 70 forks source link

Gap of the pinch gesture #167

Closed olcsa closed 3 weeks ago

olcsa commented 11 months ago

Lately we recieved user feedbacks that they accidently grab objects with the pinch gesture. We've investigated this issue and it turned out that we can grab the virtual content with wider gap between the index finger and the thumb. If i grab a window/3d icon in the HoloLens' main menu the gap is smaller (half compared to the app).

It seems that it is related to the Mixed Reality OpenXR plugin, the only change to the project we made was downgrading the plugin to 1.7.2, and it solved this pinch gesture issue.

To reproduce:

AMollis commented 10 months ago

@marlenaklein-msft , can you investigate this?

@olcsa , does the same issue occur in the MR Plugin 1.9?

olcsa commented 10 months ago

@AMollis, Yes, I've tested with the 1.9 and 1.8 too, the issue still occured.

bende01 commented 7 months ago

Hi, is there any update with this issue? I tested it with 1.10 and the problem is the same.

iantrobinson commented 7 months ago

Same here. It is very frustrating when a fairly neutral hand position suddenly grabs an object.

On Fri, Jan 12, 2024 at 9:05 AM Bendegúz Lontai @.***> wrote:

Hi, is there any update with this issue? I tested it with 1.10 and the problem is the same.

— Reply to this email directly, view it on GitHub https://github.com/microsoft/OpenXR-Unity-MixedReality-Samples/issues/167#issuecomment-1889296584, or unsubscribe https://github.com/notifications/unsubscribe-auth/APCJ6QV2JEVCTX3BULMUKDLYOE7KRAVCNFSM6AAAAAA4YNGLUCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBZGI4TMNJYGQ . You are receiving this because you are subscribed to this thread.Message ID: <microsoft/OpenXR-Unity-MixedReality-Samples/issues/167/1889296584@ github.com>

Guillaume-Git commented 5 months ago

Hi! I have the problem as well. I am stuck with 1.7.2 which has other annoying bugs that have been corrected in more recent versions. Any update on this particular issue?

marlenaklein-msft commented 5 months ago

Hi, thanks for reporting this issue. Just to confirm, this only occurs when using holographic remoting? Or also when building to device?

Guillaume-Git commented 5 months ago

Thanks for your answer. Yes I confirm that it only occurs when using holographic remoting. When I build to device, the pinch gesture works just fine.

marlenaklein-msft commented 5 months ago

I was able to repro the issue. As a test, confirmed that using the MR Plugin 1.8.0 and manually changing the HAR dlls from 2.9.1 to 2.8.1, the pinch gap behaves as normal.

@lappelsmeier, @AMollis it seems this is a change in behavior from HAR 2.8.1 to 2.9.1

Guillaume-Git commented 5 months ago

@marlenaklein-msft I would like to use the 1.10.0 version and change the HAR dlls manually to fix the pinch gap temporarily before a new version is released to fix the issue. Do you think it is possible? Where are the dlls located?

marlenaklein-msft commented 5 months ago

@Guillaume-Git I tested this by changing the dlls in the PackageCache (Library > PackageCache > com.microsoft.mixedreality.openxr > Runtime > windows > x64). I replaced the 2.9.1 HAR dlls in my 1.8.0 project with the 2.8.1 ones from my 1.7.2 project.

I'm not sure whether there are any differences in 1.10 that would prevent it from working there. This isn't an expected/supported method, just a test to narrow down the problem, so the plugin hasn't been officially validated with that version of HAR.

Guillaume-Git commented 5 months ago

Thank you! I will try this workaround for now and keep you updated.

bende01 commented 5 months ago

@Guillaume-Git Did you manage to use the workaround?

Guillaume-Git commented 5 months ago

Sorry, I haven't been able to test it yet as I'm busy with something else for the moment.

Guillaume-Git commented 2 months ago

@bende01 @marlenaklein-msft I have been able to test the workaround and it works for me as well. I have the version 1.10.1 installed and I replaced the HAR dll with the 1.7.2 version in the package cache. The pinch gesture is now working just fine. However, as my application is compiled for UWP x64, it is the universalwindows folder dll that I had to replace for the workaround to work.

AMollis commented 3 weeks ago

@olcsa this issue has been fixed in the remoting runtime v2.9.4, which is included in OpenXR MR Plugin v1.11.1

More information here:

https://github.com/microsoft/OpenXR-Unity-MixedReality-Samples/releases/tag/v1.11.1