search

microsoft / Oryx

Build your repo automatically.
Other
755 stars 174 forks source link

Support Blazor WebAssembly AOT compilation #1026

Closed anthonychu closed 2 years ago

anthonychu commented 3 years ago

Feature Request

This is a request for .NET 6 Preview 5, which is not out yet. There's a bug in Preview 4 that prevents AOT workloads from working. https://github.com/dotnet/sdk/issues/17865

Sample app: https://github.com/anthonychu/ConwayBlazor/tree/3460b8877f05a9bf099e2e473def3f45dc8924fd/Client

anthonychu commented 3 years ago

After discussion with @danroth27, updated the detection logic slightly. Any Blazor WebAssembly app on .NET 6 should have the workload installed.

qianz2 commented 3 years ago

@anthonychu, does that mean we don't need to pass in "static-sites" parameter, it will go run this command generally for .NET 6 Blazor Wasm apps? We've just opened a PR for this issue. Feel free to look into it and left some comments there. Thanks!

anthonychu commented 3 years ago

From what I can see in the PR, it looks great. Agree with not needing to check static-sites. Thanks.

anthonychu commented 3 years ago

@qianz2 @arroyc It looks like the Blazor AoT build has a dependency on Python 3.6 or higher. By default, Oryx includes Python 2.7 (python) and Python 3.5.3 (python3). Is it possible to install a newer version of Python 3 when we install this workload?

anthonychu commented 3 years ago

In .NET 6 preview 7, the workload will be renamed from microsoft-net-sdk-blazorwebassembly-aot to wasm-tools. Let's resume working on this after preview 7 is released next week and added to Oryx.

loganmarshall1 commented 3 years ago

@anthonychu , @qianz2 & @arroyc looking very forward to this update, please let me know if it will be released in time for .Net 6 GA in November?

I have 7 different blazor wasm apps that would have HUGE gains from AOT Azure Static Web App Pipeline Support!

thanks! :)

anthonychu commented 3 years ago

This has been added to Oryx. We’re working on getting it into Static Web Apps builds. November is a good guess. 😉

loganmarshall1 commented 3 years ago

Oooooh sounds like a show a tell! Love it!

Let me know if you guys want to feature any of my 7 blazor standalone pwa wasm apps running aot on azure static web apps! ;) <3.

Thank you my friend!

anthonychu commented 3 years ago

@loganmarshall1 Send me an email. Would love to hear about your projects. If any of them are on GitHub, I can share with you a totally unsupported private build of the GitHub Action that has this enabled. Interested to test it out with your apps to make sure all is working. anthony.chu@microsoft.com

loganmarshall1 commented 2 years ago

Hi @anthonychu VS 2022 launch today! ya! 👯 . Looking forward to this update! best of luck today!

arroyc commented 2 years ago

This is done.. closing it