microsoft / PQCrypto-SIDH

SIDH Library is a fast and portable software library that implements state-of-the-art supersingular isogeny cryptographic schemes. The chosen parameters aim to provide security against attackers running a large-scale quantum computer, and security against classical algorithms.
MIT License
316 stars 101 forks source link

Wrong delay loop #32

Closed j123123 closed 2 years ago

j123123 commented 4 years ago

Such delay loops: https://github.com/microsoft/PQCrypto-SIDH/blob/873f8d118ee361181d23d1b0819fd6e2abda43b3/src/random/random.c#L22-L25 may not work, because compiler can remove this. Example: https://godbolt.org/z/9bd6xd

patricklonga commented 2 years ago

This was fixed. Thanks.