microsoft / PR-Metrics

A GitHub Action & Azure Pipelines task for augmenting pull request titles to let reviewers quickly determine PR size and test coverage.

https://github.com/microsoft/Omex

MIT License

58 stars 12 forks source link

XS✔ ◾ Fixing "File Matching Patterns" Glob Logic #432

Closed muiriswoulfe closed 1 year ago

muiriswoulfe commented 1 year ago

Summary

Motivation

There are some issues with the glob "file matching patterns" logic as per issue #431.

Technical

This change fixes the issue by simplifying the logic and creating a clear hierarchy of how to apply different glob patterns. It maintains the existing logic covered by the unit tests, and tests the issue reported, for which a new unit test has been added.

Testing

Test Types

[X] Unit tests
[ ] Manual tests

Unit Test Coverage

100%

github-actions[bot] commented 1 year ago

PR Metrics

✔ Thanks for keeping your pull request small. ✔ Thanks for adding tests.		Lines
Product Code	36
Test Code	96
Subtotal	132
Ignored Code	0
Total	132

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!