microsoft / Partner-Center-Java

Partner Center SDK for Java
https://docs.microsoft.com/java/partnercenter/
31 stars 12 forks source link

InvoiceLineItemConverter cannot deserialize invoice line items with type billing_line_items and billing provider: one_time #144

Open vgupta opened 3 years ago

vgupta commented 3 years ago

After upgrading SDK from version 1.14.0 to 1.15.3, I am getting parsing exceptions for billing provider one_time.

Base Description: com.microsoft.store.partnercenter.exception.PartnerResponseParseException: Could not deserialize response. Detailed message: InvoiceLineItemConverter cannot deserialize invoice line items with type billing_line_items and billing provider: one_time (through reference chain: com.microsoft.store.partnercenter.models.ResourceCollection["items"]->java.util.ArrayList[0])

After debugging I found that BillingProvider.ONE_TIME.toString() is returning 'onetime' while it billingprovider value is one_time.

This is show stopper bug. Due to this, I am not able to process onetime invoices.

Check attached screenshot

error
vgupta commented 3 years ago

@isaiahwilliams can you please check?

vgupta commented 3 years ago

@msize Looks like this issue has been already fixed in commit https://github.com/microsoft/Partner-Center-Java/commit/0f3ccc2f14baee4b098d04e8c62a33ccc3e2f123 but not released yet. Is there any plan to release?

Due to this issue, I am not able to use API to fetch one-time invoice line items.

msize commented 3 years ago

@vgupta I'm not a staff of Microsoft and haven't any permission on this project. I'm, like you, just a user of this library.

lennydeveloper commented 2 years ago

I know it is a bit late but this may be useful for people who come in the future to review possible solutions to this specific error.

Change the version to 1.15.1

Works for me.