search

microsoft / Phi-3CookBook

This is a Phi-3 book for getting started with Phi-3. Phi-3, a family of open AI models developed by Microsoft. Phi-3 models are the most capable and cost-effective small language models (SLMs) available, outperforming models of the same size and next size up across a variety of language, reasoning, coding, and math benchmarks.
MIT License
2.31k stars 232 forks source link

fix documentation content #186

Open yuting1008 opened 2 weeks ago

yuting1008 commented 2 weeks ago

Purpose

Update the code for flow.dag.yml file in the prompt flow.

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error? If you're not sure, try it out on an old environment.

[ ] Yes
[X] No

Does this require changes to learn.microsoft.com docs?

This repository is referenced by (https://azure.microsoft.com/products/phi-3) which includes deployment, settings and usage instructions.

[ ] Yes
[X] No

Type of change

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[X] Documentation content changes
[ ] Other... Please describe:
skytin1004 commented 2 weeks ago

Hi @yuting1008, thank you for submitting the PR for this E2E sample. However, as far as I know, it worked fine without these variables. Could you please explain why these variables are needed? Also, I'd like to know what kind of bug occurs when this change is not applied.

leestott commented 6 days ago

@yuting1008 can you please confirm what the proposed changes do?