search

microsoft / Phi3-Chat-WinUI3-Sample

MIT License
32 stars 7 forks source link

Fix typo and update nuget packages #1

Closed dsjlee closed 3 months ago

dsjlee commented 3 months ago

updated Microsoft.ML.OnnxRuntimeGenAI.DirectML from v0.2.0-rc7 to v0.2.0. App now has significantly better performance when generating response.

dsjlee commented 3 months ago

@microsoft-github-policy-service agree

dsjlee commented 3 months ago

Thank you for this PR. There are few things in here that are also included that need a bit more work before I can merge this:

  • you changed the model folder name but didn't update the readme
  • you removed the config in the csproj to copy the model to the output

That's weird, when I made the pull request it only contained two commits on May 25th, not sure how the subsequent 5 commits made on May 28th gets automatically included in pull request retroactively, which are commits for my personal use. If so, then you should reject the pull request.

nmetulev commented 3 months ago

Yeah, when you create a PR, all commits from that source branch are included, even those created after the PR was created. Sorry it took so long to review, I didn't have notifications enabled and missed the PR.

I'll close this PR - feel free to submit a new one if not too much trouble.