search

microsoft / PlanetaryComputerDataCatalog

Data catalog for the Microsoft Planetary Computer
https://planetarycomputer.microsoft.com
MIT License
35 stars 15 forks source link

Datasets.yml updates #342

Closed pholleway closed 2 years ago

pholleway commented 2 years ago

datasets.yml file updates

pholleway commented 2 years ago

cc @pjhartzell

pholleway commented 2 years ago

Adding viirs notebook links before requesting review

pholleway commented 2 years ago

@mmcfarland This PR is ready for review. I don't have the permissions to add you as a reviewer. Thanks!

pholleway commented 2 years ago

Looks good. One thing: for every new ipynb referenced, we'll need to add a line in this codefiles_urls.txt file which downloads them as a separate step.

https://github.com/microsoft/PlanetaryComputerDataCatalog/blob/develop/etl/config/codefiles_urls.txt#L48

@mmcfarland Thanks for pointing that out. The ipynb references are added to the codefiles_urls.txt.

Also, the notebooks added to datasets.yml and codefiles_url.txt aren't finished yet, but I am actively working on them and should be done soon. Is it okay to add the links before the notebooks are done?

mmcfarland commented 2 years ago

Is it okay to add the links before the notebooks are done?

Yep, the build will just move on without them. The tab will start working once the notebooks exist and this site gets redeployed.