microsoft / PlanetaryComputerExamples

Examples of using the Planetary Computer
MIT License
366 stars 179 forks source link

Add DRCOG & CCLC notebooks #204

Closed pholleway closed 2 years ago

pholleway commented 2 years ago
pholleway commented 2 years ago

Issue with pre-commit. I'll make the fix soon.

pholleway commented 2 years ago

cc @gadomski

gadomski commented 2 years ago

My only comment is that the two "Displaying the data" sections could use rich.table to display the classification values. Otherwise, looks great!

pholleway commented 2 years ago

My only comment is that the two "Displaying the data" sections could use rich.table to display the classification values. Otherwise, looks great!

That's a good point. I'll make the change. Thanks for taking a look!

TomAugspurger commented 2 years ago

Thanks. I pushed a couple changes:

  1. Use pystac_client.Client rather than from pystac import Client. We also have dask.distributed.Client, so I like to fully qualify them.
  2. I think that having the class labels in a legend is important for these LULC dataset, so I constructed the plots with matplotlib rather than using the rendered_preview. This is still very painful :/
pholleway commented 2 years ago

Thanks. I pushed a couple changes:

  1. Use pystac_client.Client rather than from pystac import Client. We also have dask.distributed.Client, so I like to fully qualify them.
  2. I think that having the class labels in a legend is important for these LULC dataset, so I constructed the plots with matplotlib rather than using the rendered_preview. This is still very painful :/

Thanks for the feedback and the changes, Tom. I'll use pystac_client.Client and matplotlib colormaps next time around.