search

microsoft / Power-Fx

Power Fx low-code programming language
MIT License
3.21k stars 329 forks source link

Join function #2728

Open anderson-joyle opened 3 weeks ago

anderson-joyle commented 3 weeks ago

Join(t1, t2, LeftRecord.id = RightRecord.refid) //JoinType.Inner by default
Join(t1, t2, LeftRecord.id = RightRecord.refid, JoinType.Inner) // JoinType.Inner / JoinType.Left / JoinType.Right / JoinType.Full
Join(t1, t2, LeftRecord.id = RightRecord.refid, JoinType.Inner, LeftRecord.id As NewId, ...) // Renaming columns to avoid name collision

LucGenetier commented 2 weeks ago

✅ No public API change. #Resolved

LucGenetier commented 2 weeks ago

✅ No public API change. #Resolved

LucGenetier commented 2 weeks ago

✅ No public API change. #Resolved

LucGenetier commented 2 weeks ago

✅ No public API change. #Resolved

LucGenetier commented 2 weeks ago

✅ No public API change. #Resolved

LucGenetier commented 1 week ago

✅ No public API change. #Resolved

LucGenetier commented 1 week ago

✅ No public API change. #Resolved

LucGenetier commented 6 days ago

✅ No public API change. #Resolved

LucGenetier commented 6 days ago

✅ No public API change. #Resolved

LucGenetier commented 5 days ago

✅ No public API change. #Resolved

LucGenetier commented 5 days ago

✅ No public API change. #Resolved

LucGenetier commented 4 days ago

✅ No public API change. #Resolved

CarlosFigueiraMSFT commented 4 days ago 
            for (var i = 1; i < carg; i++)

Suggestion: start from ScopeArgs instead of 1; we don't need to do any of the logic inside this loop for any of the scope arguments, since they have already been visited (we'd need to move line 4655 (argTypes[i] = _txb.GetType(args[i])) to line 4575 after we visited it

Refers to: src/libraries/Microsoft.PowerFx.Core/Binding/Binder.cs:4623 in a438704. [](commit_id = a438704adee7a6e3f87e47859c717dbe3fa5f0fa, deletion_comment = False)

LucGenetier commented 2 days ago

✅ No public API change. #Resolved