Closed arpavan closed 1 year ago
Nice work, would be nice if you can make the newly added testplan part of integration test workflow run https://github.com/microsoft/PowerApps-TestEngine/blob/main/.github/workflows/build-test.yml
Nice work, would be nice if you can make the newly added testplan part of integration test workflow run https://github.com/microsoft/PowerApps-TestEngine/blob/main/.github/workflows/build-test.yml
@NavneetThekkumpat there's already a separate work item that addresses this
Package | Line Rate | Branch Rate | Complexity | Health |
---|---|---|---|---|
Microsoft.PowerApps.TestEngine | 94% | 90% | 790 | ✔ |
Summary | 94% (2146 / 2290) | 90% (485 / 538) | 790 | ✔ |
Minimum allowed line rate is 50%
Description
This PR adds support to Test Engine to recognize test plans that were created in different locales, this wasn't supported so far and any test plan that was written in a different locale that consisted of variations in syntax (e.g.,
;
for,
and,
for.
in some EU locales) would actually break during parsing and execution. Issue #150 has been reported in this regard, and this PR among other upcoming ones addresses this by adding an enhancement to Test Engine to recognize locales.Changes in this PR include adding the
Locale
field to theTestSettings
class, adding necessaryINFO
logs to indicate usage of locale andERROR
logs when unrecognized test is used in the locale field. Unit tests have been updated and a new test has been added to cover this change.NOTE: Currently there's some weird behavior with unit tests where the tests will pass even if I provide bad test data. However I'm requesting reviews of the overall solution while I'm addressing the unit test. The functionality works accurately when run end to end with real test plan files.
Checklist