microsoft / PowerApps-TestEngine

MIT License

98 stars 29 forks source link

added locale to testSettings.yaml sample file #209

Closed arpavan closed 1 year ago

arpavan commented 1 year ago

Description

Added the locale property to the testSettings.yaml sample file as well. This is not a breaking change, and was missed in a previous PR.

Checklist

[N/A] The code change is covered by unit tests. I have added tests that prove my fix is effective or that my feature works
[N/A] I have performed end-to-end test locally.
[N/A] New and existing unit tests pass locally with my changes
[N/A] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I used clear names for everything
[X] I have performed a self-review of my own code

clairewu0218 commented 1 year ago

You may want to remove this line as it's not actually working

NavneetThekkumpat commented 1 year ago

Also would be great to update src\Microsoft.PowerApps.TestEngine.Tests\Config\YamlTestConfigParserTests.cs too

arpavan commented 1 year ago

Also would be great to update src\Microsoft.PowerApps.TestEngine.Tests\Config\YamlTestConfigParserTests.cs too

@NavneetThekkumpat I intentionally left some of those out to cover the scenario for unspecified locale. There's an additional test in there that specifically looks for the locale field. Let me know if that is okay

NavneetThekkumpat commented 1 year ago

Also would be great to update src\Microsoft.PowerApps.TestEngine.Tests\Config\YamlTestConfigParserTests.cs too

@NavneetThekkumpat I intentionally left some of those out to cover the scenario for unspecified locale. There's an additional test in there that specifically looks for the locale field. Let me know if that is okay

Also would be great to update src\Microsoft.PowerApps.TestEngine.Tests\Config\YamlTestConfigParserTests.cs too

@NavneetThekkumpat I intentionally left some of those out to cover the scenario for unspecified locale. There's an additional test in there that specifically looks for the locale field. Let me know if that is okay

Oh Sure, that works then. Thank you!

arpavan commented 1 year ago

You may want to remove this line as it's not actually working

@clairewu0218 cleaned up this and similar duplicate references in other plans as well. thanks for pointing this out!

github-actions[bot] commented 1 year ago

Package	Line Rate	Branch Rate	Complexity	Health
Microsoft.PowerApps.TestEngine	93%	89%	800	✔
Summary	93% (2171 / 2330)	89% (490 / 548)	800	✔

Minimum allowed line rate is 50%