microsoft / PowerApps-TestEngine

MIT License
93 stars 28 forks source link

Avoid GoToUrlAsync from Timing Out Due To Network Idle #269

Closed arpavan closed 1 year ago

arpavan commented 1 year ago

Description

Due to frequent instances of timeouts during test execution, we've decided to remove the WaitUntil = WaitUntilState.NetworkIdle property from the GotoAsync invocation. From the Playwright documentation, it has been suggested NOT to use the NetworkIdle property due to its nature of timing out explicitly at 500ms which is undesirable in a real-world scenario (since we can never expect real world network reliability within such tight tolerances).

By removing the explicit setting, the WaitUntil property defaults to the JavaScript Window.Load event. This makes this function call more robust as it waits until the entire page loads and will timeout only at the predefined default timeout.

Checklist

github-actions[bot] commented 1 year ago

Code Coverage

Package Line Rate Branch Rate Complexity Health
Microsoft.PowerApps.TestEngine 90% 88% 912
Summary 90% (2377 / 2630) 88% (556 / 630) 912

Minimum allowed line rate is 85%