microsoft / PowerApps-TestEngine

MIT License
101 stars 29 forks source link

Refactor DateValue field and fix other compile time errors #275

Closed arpavan closed 1 year ago

arpavan commented 1 year ago

Description

With the upgrade to PowerFx.Interpreter from 0.2.3-preview to 0.2.6-preview, some implementation details have changed -

  1. DateValue.Value is now deprecated in favor of DateValue.GetConvertedValue(timeZone), and if timeZone is null, it will use the local timezone. This change has been made to factor this in without change in functionality.
  2. The locale parameter has been temporarily removed from PowerFxConfig constructor to unblock us from fixing other compile time errors, and work on this fix and test it in isolation.
  3. The implementation of IUntypedObject interface has been updated per the updated interface.

Most of the checklist items are not applicable as these are in-progress changes being done on an intermediate branch to facilitate parallel efforts on the many compile time errors that this is addressing.

NOTE: This change is being merged into the intermediate feature branch currently. Once all the compile time breaking changes have been addressed and tests are passing we will merge this feature branch into main, for full review of all the compile time fixes at once.

Checklist