microsoft / PowerApps-Tooling

Tooling support for PowerApps language and .msapp files
https://make.powerapps.com
MIT License
322 stars 107 forks source link

`PersistenceException` standardization #645

Closed joem-msft closed 5 months ago

joem-msft commented 5 months ago

Problem

We need to standardize on the custom exceptions that we throw and allow the DocServer to emit actionable error messages to the user if possible.

Solution

This PR adapts our existing PersistenceException to require an ErrorCode and allows it to be used in more general scenarios. We also shore up the APIs for serializing/deserializing yaml and json to wrap exceptions coming from the serialization libraries.

Changes

Validation

Tests updated and new ones added.