search

microsoft / PowerApps-Tooling

Tooling support for PowerApps language and .msapp files
https://make.powerapps.com
MIT License
303 stars 102 forks source link

Cannot unpack canvas app with Modern Controls Combobox & Dropdown #668

Open rontan09 opened 4 weeks ago

rontan09 commented 4 weeks ago

Describe the bug

Not able to unpack msapp file with Modern Control with the latest version of powerapps "3.24054.19". It was previously working fine until last week.

I created a test app for troubleshooting and found out issue also appearing.

To Reproduce

Steps to reproduce the behavior:

  1. Unpacking pac canvas unpack --msapp ModernControlv2.msapp --sources ./ModernControlv2

pac canvas unpack --msapp ModernControlv2.msapp --sources ./ModernControlv2 Warning: canvas unpack is in preview, and functionality is not guaranteed. Use extreme caution if using in a production environment. For more information see https://aka.ms/paccanvas Unpack from C:\src\papps\ModernControlv2.msapp --> C:\src\papps\ModernControlv2 Microsoft PowerPlatform CLI Version: 1.32.8+gf89d946 Online documentation: https://aka.ms/PowerPlatformCLI Feedback, Suggestions, Issues: https://github.com/microsoft/powerplatform-build-tools/discussions

Error: Error PA3999: Unable to parse template file PowerApps_CoreControls_DropdownCanvasTemplate_dataField

rontan09 commented 4 weeks ago

ModernControlv2.zip

Sample App with Modern Control ( Combobox with Field) & Dropdown with Field)

image

rfarris2000 commented 3 weeks ago

Line 62 in ControlParserTemplate.cs is throwing a duplicate key exemption.

Method is TryParseTemplate.

petrochuk commented 3 weeks ago

Sorry you ran into this issue. As announced during Microsoft Build conference the direction is to eliminate the need for this pack/unpack tool

rfarris2000 commented 3 weeks ago

What kind of answer is that? That's great that is planned to eliminate but this is a bug right now that is preventing us from committing to source control.

petrochuk commented 3 weeks ago

What kind of answer is that? That's great that is planned to eliminate but this is a bug right now that is preventing us from committing to source control.

Thank you for providing your feedback. We will work on making it clearer that PaSopa has always been an experimental tool and is not recommended for production use. We have included multiple warnings in the documentation to indicate this:

https://github.com/microsoft/PowerApps-Tooling/tree/master/src/PASopa https://github.com/microsoft/PowerApps-Tooling/blob/master/docs/YAMLFileFormat.md

Here is the blog post where you can learn more: Introducing Code View in Power Apps Studio (Public Preview)

petrochuk commented 3 weeks ago

What kind of answer is that? That's great that is planned to eliminate but this is a bug right now that is preventing us from committing to source control.

FYI: This project is open-sourced, and we welcome contributions from the community. If you have a proposed fix, please feel free to open a pull request and we will be happy to review it.

marcelbf commented 3 weeks ago

Workaround at the moment is to save the .msapp in a previous version

you can add &studio-version=v3.24052.30.298708436 to the URL within PowerApps Studio as listed here

pkm90 commented 2 weeks ago

Sorry you ran into this issue. As announced during Microsoft Build conference the direction is to eliminate the need for this pack/unpack tool

Do you know have a source or a link that talks more about this? I've found is this brief description under the "Use first-class DevOps" section: https://www.microsoft.com/en-us/power-platform/blog/power-apps/power-apps-is-making-it-easier-for-developers-to-build-with-microsoft-copilot-and-each-other/

It doesn't look like there's any option to control what is being pushed from a solution so multiple people wouldn't be able to work on the same component...

petrochuk commented 2 weeks ago

@pkm90

Good overview: Enable every developer to collaborate with low code + pro code | BRK202

There are also Community Office Hours that are open to the public to join (third (3rd) Thursday of the month between 11:00am - 12:00pm US Pacific Time - Excluding holidays) where you can talk and provide feedback to some team members directly.

I hope this helps.

rrrahate commented 2 weeks ago

Workaround at the moment is to save the .msapp in a previous version

you can add &studio-version=v3.24052.30.298708436 to the URL within PowerApps Studio as listed here

I added the working studio version but still no success.

marcelbf commented 2 weeks ago

I added the working studio version but still no success.

are you sure it is the same issue? Can you easily repro with a sample .msapp that you can send?

This PR fixed this specific issue - had confirmation from more than one user that it works, and we are planning to release to PAC CLI very soon.

rfarris2000 commented 1 week ago

I added the working studio version but still no success.

are you sure it is the same issue? Can you easily repro with a sample .msapp that you can send?

This PR fixed this specific issue - had confirmation from more than one user that it works, and we are planning to release to PAC CLI very soon.

Any update on the PAC CLI fix?

wojtasey commented 1 week ago

We are also waiting for the pac cli fix. I reported my issue in the discussion section:

https://github.com/microsoft/powerplatform-build-tools/discussions/941

rrrahate commented 1 week ago

What is the tentative release date for PAC CLI update to fix this issue? @marcelbf