microsoft / PowerBI-Icons

Icons (PNG and SVG) for Power BI
Creative Commons Attribution 4.0 International
433 stars 208 forks source link

Missing icons #14

Closed tirnovar closed 2 years ago

tirnovar commented 3 years ago

Hello everyone,

thank you for your incredible work! Here I am sending a list of icons that I think are missing here:

1) Workbook 2) Promoted badge 3) Certified badge 4) Calculation Groups 5) Streaming Dataflows

Kind regards Štěpán Rešl

marclelijveld commented 2 years ago

I believe the workbook has the same icon as a dataset in the Power BI Service nowadays. But please correct me if I'm wrong @tirnovar

tirnovar commented 2 years ago

Hey Marc, unfortunately, the workbook has a different icon.

image
marclelijveld commented 2 years ago

Interesting.... I just uploaded a workbook in a new workspace, and it showed for me as a generic dataset. Let me try that again @tirnovar. Other than that, I just created pull request 15 to add the streaming dataflow icon.

marclelijveld commented 2 years ago

Also added a (re-created) icon for workbooks now. There seems to be a difference in how you import the workbook. (import / connect). Created something like the Excel Workbook icon in the same matching style as all other icons and created pull request 16 for that.

jeroenterheerdt commented 2 years ago

Added icons for no5 and no1 on your list: https://github.com/microsoft/PowerBI-Icons/commit/161023475b19f5cdba6835e2fcc24179fe87cc28.

jeroenterheerdt commented 2 years ago

no4 calculation groups are not supported in Desktop officially, so the icon was really chosen by TE or other external tools, so I cannot add an official icon for it. The badges (no2, no3) I am not sure if we can add those, they are not real icons..

tirnovar commented 2 years ago

Thank you so much for adding no1 & no5. I understand that no4 can't be counted. But no2 & no3 have their icons inside PBIS same "icons" are shown when I want to add Power BI Dataset to model in PBID.

image
jeroenterheerdt commented 2 years ago

look what I found ;). Calc groups is the only one that does not have an official icon.

tirnovar commented 2 years ago

Absolutely awesome! I think we can close this issue 🤩