search

microsoft / PowerBI-Node

Node SDK and client library for Power BI REST APIs.
https://dev.powerbi.com
Other
79 stars 31 forks source link

Update SDK to use v1.0 APIs #10

Closed aluong closed 8 years ago

aluong commented 8 years ago

Removed unnecessary dev and provision token generation Reran autorest to generate new v1.0 calls Updated corresponding documentation

msftclas commented 8 years ago

Hi @aluong, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Andy Luong). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

wbreza commented 8 years ago

LGTM

mattmazzola commented 8 years ago

I thought that using Provision and Dev tokens was going to continue to work for a while after GA? Shouldn't these features stay in for people already setup to use this type of auth but with deprecated warning and only remove them when the service stops accepting those types of tokens?

wbreza commented 8 years ago

@mattmazzola Yes, it will continue to work if you use the old SDK version. I don't see a need to keep it in the new version.

@aluong - Please bump major version in package.json