Open diego-d5000 opened 7 years ago
Sorry. I started from master at the beginning, so I made a rebase to "dev" branch to change the parent branch.
@ali-hamud could you check it please ?
Hi Diego, Thank you for the pull request. As we got more requests to update this, we will give it higher priority. I"ll look into it next week.
Hi, Code looks OK except of the Import code. Import code is still using azure Workspace collections and didn't moved to the new pattern. Do you want me to take it from here?
Another thing: calling super from constructor throws this error: Class constructor PowerBIClient cannot be invoked without 'new'
I think This is related to changes of versions in package.json and typings file.
Thanks for the review @ali-hamud I'll check it to commit the fixes
@ali-hamud I would apreciated if you could help me with the Imports code and some test for replicate the error. Thanks
sure. I provide it tomorrow.
I succeeded to solve the issue. I will update later.
Any updates on this? @ali-hamud
Please note that we have deprecate this library.
That's unfortunate @ali-hamud.
Description
Questison
please answer the following questions. put x inside [ ] (e.g. [x])
What inside?
Is pull request totally generated from swagger file?
Backward compatibility break?
Learn more about backward compatibility.