microsoft / PowerBI-Node

Node SDK and client library for Power BI REST APIs.
https://dev.powerbi.com
Other
79 stars 31 forks source link

Update SDK to V2 #41

Open diego-d5000 opened 7 years ago

diego-d5000 commented 7 years ago

Description

Questison

please answer the following questions. put x inside [ ] (e.g. [x])

What inside?

Is pull request totally generated from swagger file?

Backward compatibility break?

Learn more about backward compatibility.

diego-d5000 commented 7 years ago

Sorry. I started from master at the beginning, so I made a rebase to "dev" branch to change the parent branch.

diego-d5000 commented 7 years ago

@ali-hamud could you check it please ?

ali-hamud commented 7 years ago

Hi Diego, Thank you for the pull request. As we got more requests to update this, we will give it higher priority. I"ll look into it next week.

ali-hamud commented 7 years ago

Hi, Code looks OK except of the Import code. Import code is still using azure Workspace collections and didn't moved to the new pattern. Do you want me to take it from here?

ali-hamud commented 7 years ago

Another thing: calling super from constructor throws this error: Class constructor PowerBIClient cannot be invoked without 'new'

I think This is related to changes of versions in package.json and typings file.

diego-d5000 commented 7 years ago

Thanks for the review @ali-hamud I'll check it to commit the fixes

diego-d5000 commented 7 years ago

@ali-hamud I would apreciated if you could help me with the Imports code and some test for replicate the error. Thanks

ali-hamud commented 7 years ago

sure. I provide it tomorrow.

ali-hamud commented 7 years ago

I succeeded to solve the issue. I will update later.

naknode commented 6 years ago

Any updates on this? @ali-hamud

ali-hamud commented 6 years ago

Please note that we have deprecate this library.

naknode commented 6 years ago

That's unfortunate @ali-hamud.