search

microsoft / PowerBI-visuals-tools

Contains tools for building/packaging Power BI visuals
https://www.powerbi.com
MIT License
330 stars 149 forks source link

ssl certificate doesn't installs #448

Closed Alexandervelilyaev closed 11 months ago

Alexandervelilyaev commented 1 year ago

After version 4.0.5 ssl certificate doesn't installing. In the v4.0.5 we use pass phrase. Now it doesn't require pass phrase and certificate doesn't work. Please fix.

j-murray1 commented 1 year ago

I can confirm this issue. In pbiviz v4.0.6+ there was a change where certificate file(s) are provided in the 'certs' folder during install. You can still run 'pbiviz --install-cert' and it states that it runs successfully (and does not ask for a passcode), but if you then try and package a custom visual you will be told your certificate is not valid. If you delete the install-provided certificate file(s) then execute 'pbiviz --install-cert' the process is identical to previous versions and the generated certificate is valid.

Alexandervelilyaev commented 1 year ago

@j-murray1 , thank you for the details. Could you please provide more details about this point:

"If you delete the install-provided certificate file(s)"

Where can I find them?

Thank you in advance

danglotor commented 1 year ago

I can also confirm this issue. The certificate is called "PowerBICustomVisualTest_public.crt" so maybe it is some test version? I tried to delete the installed certificate and install it again multiple times, for user, for machine, automatically, manually... powerbi-visuals-tools version - 4.3.0

edit: OS Windows 22H2 19045.2846

zBritva commented 1 year ago

@Alexandervelilyaev @danglotor Could you provide the error output?

Is there an error in loading the certificate to the storage of OS? Is there an error in loading the certificate by browser (Browser says cert if not valid)?

There no changes in tools code related to certificates since Dec 1, 2021 according history of GitHub.

And why do you really need to install this certificate?

pbiviz start should also generate a certificate before starting dev server.

j-murray1 commented 1 year ago

@j-murray1 , thank you for the details. Could you please provide more details about this point:

"If you delete the install-provided certificate file(s)"

Where can I find them?

Thank you in advance

Sorry for the delayed response on this. They are located in the certs folder of the powerbi-visuals-tools folder structure. Explicitly: npm/node_modules/powerbi-visuals-tools/certs

Hope this helps!

AleksSavelev commented 11 months ago

As @zBritva already mentioned pbiviz start should also generate a certificate before starting the dev server. Closing this issue for now as completed, but feel free to reopen it, if the problem still appears