search

microsoft / PowerBI-visuals-tools

Contains tools for building/packaging Power BI visuals
https://www.powerbi.com
MIT License
330 stars 149 forks source link

In the webpacked css the url() values are not replaced with a base64 strings anymore #450

Closed Tibart closed 1 year ago

Tibart commented 1 year ago

https://github.com/microsoft/PowerBI-visuals-tools/blob/60f7ee2dbdb8e26a94f2b514c389b2d8782fc66b/lib/webpack.config.js#L42

Sinds version 4.1.0 the file path in the css url() functions are not converted to base64 strings anymore. The url() value is changed to a random filename, e.g. background-image: url(assets2f9217098f9e7268bf00.svg). Wat I expected was something like this: background-image: url(data:image/svg+xml;charset=utf-8;base64,PD94bWwgdmVyc2lvbj0iMS4wIiBlbm...RhPg0KPC9zdmc+DQo=).

I tried to figure out why this is changed but could not see modification that could cause this behaviour. The 'base64-inline-loader' module is unaltered but for some reason is not used in the less to css conversion.

Tibart commented 1 year ago

Issue seems to be fixed in 4.2.1. https://github.com/microsoft/PowerBI-visuals-tools/releases/tag/4.2.1